LIGO Support Ticket 18922

Ticket Information
  Number:      admin 18922
  User:        anderson@ligo.caltech.edu
  Email:       condorligo__AT__aei.mpg.de
  Status:      resolved
  Assigned To: jfrey

From: Stuart Anderson <anderson__AT__ligo.caltech.edu>
To: condor-admin__AT__cs.wisc.edu
Subject: LIGO: condor_preen exits unless INVALID_LOG_FILES is specified
Date: Sun, 18 Jan 2009 21:38:23 -0800
CC: Condor/LIGO mailing list <condorligo__AT__aei.mpg.de>
X-Seen-BY: mailfromd 4.1 silica.cs.wisc.edu

The spool directory is not cleaned if INVALID_LOG_FILES is not  
specified for,
# condor_version
$CondorVersion: 7.2.0 Dec 19 2008 BuildID: 121001 $
$CondorPlatform: X86_64-LINUX_RHEL3 $

For example, on the LIGO Condor pool the following default  
condor_config setting was commented out,

##  What files should condor_preen remove from the log directory?
#INVALID_LOG_FILES      = core

to retain core files in order to help debug other Condor problems.  
However, I just realized that this results in condor_preen not doing  
any cleanup, i.e.,

# condor_preen
ERROR "INVALID_LOG_FILES not specified in config file" at line 578 in  
file preen.cpp


I would like to argue that configuring condor_preen to not delete any  
files in the log directory should not prevent it from cleaning up in  
the spool directory.

Thanks.

--
Stuart Anderson  anderson__AT__ligo.caltech.edu
http://www.ligo.caltech.edu/~anderson




===========================================================================
Date of creation: Sun Jan 18 23:38:49 2009 (1232343532)

Subject: Actions

Assigned to jfrey by jfrey
===========================================================================
Date of actions: Wed Jan 21 10:40:53 2009 (1232556053)

From: Jaime Frey <jfrey__AT__cs.wisc.edu>
To: condor-admin__AT__cs.wisc.edu
Subject: Re: [condor-admin #18922] LIGO: condor_preen exits unless
 INVALID_LOG_FILES is specified
Date: Wed, 21 Jan 2009 11:04:17 -0600

> The spool directory is not cleaned if INVALID_LOG_FILES is not
> specified for,
...
>
> I would like to argue that configuring condor_preen to not delete any
> files in the log directory should not prevent it from cleaning up in
> the spool directory.


You can have condor_preen not delete any files from the log directory  
and still perform cleanup by setting the following:
INVALID_LOG_FILES =

However, I agree that not setting INVALID_LOG_FILES shouldn't prevent  
condor_preen from cleaning up at least the spool and execute  
directories.

Thanks and regards,
Jaime Frey
UW-Madison Condor Team



===========================================================================
Date mail was appended: Wed Jan 21 11:04:18 2009 (1232557459)

Subject: Actions

Status changed from open to pending by jfrey
===========================================================================
Date of actions: Wed Jan 21 11:04:18 2009 (1232557460)

From: Jaime Frey <jfrey__AT__cs.wisc.edu>
To: condor-admin__AT__cs.wisc.edu
Subject: Re: [condor-admin #18922] LIGO: condor_preen exits unless
 INVALID_LOG_FILES is specified
Date: Mon, 26 Jan 2009 16:40:43 -0600

I just committed a change for Condor 7.3.0 that will let condor_preen  
run even if VALID_SPOOL_FILES or INVALID_LOG_FILES is unset. If  
VALID_SPOOL_FILES is unset, the spool directory is skipped, but  
execute and log are still cleaned. If INVALID_LOG_FILES is unset, then  
all directories are cleaned and nothing in the log directory is  
considered invalid.

Thanks and regards,
Jaime Frey
UW-Madison Condor Team



===========================================================================
Date mail was appended: Mon Jan 26 16:40:48 2009 (1233009649)

Subject: Actions

Ticket resolved by jfrey
===========================================================================
Date of actions: Mon Jan 26 16:40:48 2009 (1233009650)